Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[storage] Single Errgroup Pool for BlockWorkers #272

Merged
merged 6 commits into from
Dec 9, 2020
Merged

[storage] Single Errgroup Pool for BlockWorkers #272

merged 6 commits into from
Dec 9, 2020

Conversation

patrick-ogrady
Copy link
Contributor

@patrick-ogrady patrick-ogrady commented Dec 8, 2020 •
edited
Loading

This PR updates BlockWorkers to use a single errgroup when adding/removing a block instead of a unique one for each worker (requiring synchronization at the end of each worker spawn).

Changes

  • Update BlockWorker interface to accept errgroup
  • Update BlockWorker implementations to use single errgroup
  • Update tests
  • Add argument to block worker initializer to specify the number of BlockWorker executors to run

@coveralls
Copy link

coveralls commented Dec 9, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 13560

  • 19 of 23 (82.61%) changed or added relevant lines in 3 files are covered.
  • 21 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.007%) to 78.089%
Changes Missing Coverage Covered Lines Changed/Added Lines %
storage/modules/block_storage.go 11 15 73.33%
Files with Coverage Reduction New Missed Lines %
asserter/network.go 21 86.22%
Totals Coverage Status
Change from base Build 13531: 0.007%
Covered Lines: 8065
Relevant Lines: 10328
💛 - Coveralls

@patrick-ogrady patrick-ogrady changed the title [storage] Global Errgroup [storage] Single Errgroup Pool for BlockWorkers Dec 9, 2020
yfl92
yfl92 approved these changes Dec 9, 2020
View reviewed changes
Copy link

@yfl92 yfl92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patrick-ogrady patrick-ogrady merged commit e0b5a3f into master Dec 9, 2020
@patrick-ogrady patrick-ogrady deleted the patrick/unified-errgroup branch December 9, 2020 10:26
@patrick-ogrady patrick-ogrady mentioned this pull request Dec 9, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfl92 yfl92 yfl92 approved these changes

@septerr septerr Awaiting requested review from septerr

@qiwu7 qiwu7 Awaiting requested review from qiwu7

@cindyxkuang cindyxkuang Awaiting requested review from cindyxkuang

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@patrick-ogrady @coveralls @yfl92